Better emphasis on developing and using the stackclub package#121
Merged
Better emphasis on developing and using the stackclub package#121
Conversation
kadrlica
approved these changes
Sep 14, 2018
GettingStarted/GettingStarted.md
Outdated
| This enables you to repeatedly `import stackclub` as you update the library code. | ||
| This enables you to repeatedly `import stackclub` as you update the library code. The above lines are in the [template notebook](templates/template_Notebook.ipynb), for your convenience. | ||
|
|
||
| If you are not developing this package, you can install it using pip, like this: |
Contributor
There was a problem hiding this comment.
This will only work if you have permission to write to your base python site-packages.
Contributor
|
There is also a permission issue with the pip install directions in FindingDocs.ipynb. |
Contributor
|
There is also an issue with this instruction in FindingDocs.ipynb. If you are actually in the top level of the StackClub repo, I think that you don't need the |
Contributor
Author
|
Thanks @kadrlica - I think I fixed the problems you identified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out I had already added some notes to the Getting Started file, but I think the emphasis was a bit off - you're right that everyone should set up the package, just so they can use it.