Fix Microsoft API change (Fix for #81)#85
Fix Microsoft API change (Fix for #81)#85moritzgrede wants to merge 2 commits intoLOLINTERNETZ:mainfrom
Conversation
This does not include an updated certificate! The certificate still is valid for the old domain.
|
For more information on the internet connections made by VS Code: https://code.visualstudio.com/docs/setup/network |
There was a problem hiding this comment.
Btw I have no idea why GitHub shows the whole file as changed. This file didn't change at all.
There was a problem hiding this comment.
Same for this; I have no idea why everything counts as changed. Only lines 10 through 18 changed.
|
I manually diffed the changes and there's a bit more changed in vscoffline/vsc.py beyond the scope of your comments. I'm also guessing the line endings are different and/or possibly a formatter. I generally also pull the PR and run it to check if it executes cleanly which it didn't seem to do. Likely because of the recommended extension check/fix suggested by @AndreasAhlbeck in #81 also fails as it's not in the PR. I'm going to hold off on merging this actual PR, and opt for a separate clean PR which resolves #81 and related #87 . |
2 participants
To fix #81 and simplify / speed up the process, I pulled these two commits from my other PR #84. This should fix the api change from Microsoft that didn't allow for downloads of extensions anymore.
Again, many thanks to @AndreasAhlbeck #81 (comment).