Selection of test setup improvements#239
Closed
pimterry wants to merge 3 commits intoKong:masterfrom
httptoolkit:fix-tests
Closed
Selection of test setup improvements#239pimterry wants to merge 3 commits intoKong:masterfrom httptoolkit:fix-tests
pimterry wants to merge 3 commits intoKong:masterfrom
httptoolkit:fix-tests
Conversation
Contributor
|
hey @pimterry! thankfully this was implemented in #248. I hadn't seen your solution so the way it was done there is slightly different, but suffice to say: yes! I totally agree that it left a lot to be desired before. Take a look at the new implementation here: httpsnippet/src/targets/targets.test.ts Line 57 in d4bebe4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Last PR today I promise! Sorry for all the noise)
This PR fixes a few issues I ran into in putting together the other two:
CODECLIMATE_REPO_TOKENin this repo.You can see a passing test build of this in the actions on my repo here: https://github.com/httptoolkit/httpsnippet/actions/runs/1555694270