Skip to content

Add typescript definitions and expose lineWidth in vtkGeometryRepresentationProxy#2906

Merged
floryst merged 1 commit intoKitware:masterfrom
jadh4v:feat-add-typescriptdef-GeometryRepresentationProxy
Sep 5, 2023
Merged

Add typescript definitions and expose lineWidth in vtkGeometryRepresentationProxy#2906
floryst merged 1 commit intoKitware:masterfrom
jadh4v:feat-add-typescriptdef-GeometryRepresentationProxy

Conversation

@jadh4v
Copy link
Collaborator

@jadh4v jadh4v commented Aug 31, 2023

Context

Required for VolView development: Kitware/VolView#359

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: latest master
    • OS: Windows 11, Pro
    • Browser: Chrome Version 116.0.5845.140 (Official Build) (64-bit)

@jadh4v jadh4v force-pushed the feat-add-typescriptdef-GeometryRepresentationProxy branch from 1878cb7 to 241253f Compare August 31, 2023 16:36
@jadh4v jadh4v requested a review from finetjul August 31, 2023 16:42
@finetjul finetjul requested a review from daker September 1, 2023 07:29
@jadh4v jadh4v changed the title Add typescript definitions and expose lineWith in vtkGeometryRepresentationProxy Add typescript definitions and expose lineWidth in vtkGeometryRepresentationProxy Sep 1, 2023
Copy link
Collaborator

@daker daker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue Sep 5, 2023
Merged via the queue into Kitware:master with commit b99fda2 Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This PR is included in version 28.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Sep 5, 2023
@jadh4v jadh4v deleted the feat-add-typescriptdef-GeometryRepresentationProxy branch September 19, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants