Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
approved these changes
Jun 10, 2025
Collaborator
PaulHax
left a comment
PaulHax
left a comment
There was a problem hiding this comment.
Pretty sweet.
Switching between images can be a bit strange though as last images min/max is kept...
Contributor
Author
|
Do we think it's better to save threshold values with each image during switching? |
Contributor
Author
|
I pushed changes to fix the styling and updating the threshold on image switch. I can see reasoning for preserving the threshold values for each image. @PaulHax what do you think? |
Collaborator
That makes sense, but i'm good with punting and tackling in "multi-image multi-view" work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds thresholding capabilities to painting.