fix(dicom): load images with NumberOfFrames == 1#745
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
approved these changes
May 22, 2025
Collaborator
PaulHax
left a comment
PaulHax
left a comment
There was a problem hiding this comment.
Better. Maybe we leave the issue open or make another to deal with these DICOM series types?
Contributor
Author
|
I'm sure such a series of DICOM exists, but as we don't have test data for it I think we can close it for now with a comment saying that we will re-open if this comes up again in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #744
DICOM images can have NumberOfFrames set to "1".
Throw an error when encountering a series of DICOM slices where the first one is multi-frame, since we don't handle those right now (and I have no test data to validate against).