feat(crosshairs): add hold key for temp crosshairs tool#743
Merged
floryst merged 1 commit intoKitware:mainfrom May 27, 2025
Merged
feat(crosshairs): add hold key for temp crosshairs tool#743floryst merged 1 commit intoKitware:mainfrom
floryst merged 1 commit intoKitware:mainfrom
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
force-pushed
the
crosshairs-toggle
branch
2 times, most recently
from
370345e to
85d52db
Compare
PaulHax
commented
May 22, 2025
PaulHax
force-pushed
the
crosshairs-toggle
branch
from
85d52db to
6544a11
Compare
PaulHax
commented
May 22, 2025
Contributor
|
I forgot to submit my review. I'm wondering if we should special-case disable the temp crosshairs when in crosshairs mode. Nothing breaks, so I'm fine leaving it as-is. |
PaulHax
force-pushed
the
crosshairs-toggle
branch
from
6544a11 to
cbc586e
Compare
Collaborator
Author
There was a subtle bug here (dragging was stuck on if crosshairs was already selected and temp crosshairs was toggled). Also a bug with pressing 'p' twice for paint. So added a check to do nothing if tool already active in store/tools/index.ts |
PaulHax
force-pushed
the
crosshairs-toggle
branch
from
cbc586e to
da5eba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.