Stop double reseting camera on switching images or after loading from state file #739
Merged
floryst merged 1 commit intoKitware:mainfrom May 16, 2025
Merged
Stop double reseting camera on switching images or after loading from state file #739floryst merged 1 commit intoKitware:mainfrom
floryst merged 1 commit intoKitware:mainfrom
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
changed the title
floryst
reviewed
May 15, 2025
src/store/view-configs/camera.ts
Outdated
| export const useViewCameraStore = defineStore('viewCamera', () => { | ||
| const imageStore = useImageStore(); | ||
| const configs = reactive<DoubleKeyRecord<CameraConfig>>({}); | ||
| const initializedCameras = ref(new Set<string>()); |
Contributor
There was a problem hiding this comment.
Minor memory leak; I don't see where entries get removed from initializedCameras.
floryst
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.