feat: Keyboard shortcut to delete current image and clear scene#706
feat: Keyboard shortcut to delete current image and clear scene#706lchauvin wants to merge 0 commit intoKitware:mainfrom
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
floryst
left a comment
floryst
left a comment
There was a problem hiding this comment.
Whatever your final keybinds are, please add them to https://github.com/Kitware/VolView/blob/main/docs/mouse_controls.md.
I changed the shortcut to add modifier, and modified mouse_controls.md |
src/composables/actions.ts
Outdated
|
|
||
| const deleteCurrentImage = () => () => { | ||
| const datasetStore = useDatasetStore(); | ||
| datasetStore.remove(datasetStore.primaryImageID!); |
There was a problem hiding this comment.
I'm all for updating datasetStore.remove so that we can pass in null image IDs without checking. That way we can drop the ! operator here.
remove(id: string | null) {
if (!id) return
...
}
There was a problem hiding this comment.
I added the changes
|
I was trying to squash some of lchauvin's commits and rebase rather than merge on main... but messed up force pushing them back on this PR =/ Guess we just use #713 |
3 participants
Add a keyboard shortcut to delete the current image (ctrl+d), and clear the whole scene (ctrl+w)