Skip to content

Segments: opacity slider and visibile toggle#669

Merged
PaulHax merged 7 commits intoKitware:mainfrom
PaulHax:segment-opacity
Oct 23, 2024
Merged

Segments: opacity slider and visibile toggle#669
PaulHax merged 7 commits intoKitware:mainfrom
PaulHax:segment-opacity

Conversation

@PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Oct 17, 2024

image

@netlify
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1bc37fe
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/67190df923929100083906a9
😎 Deploy Preview https://deploy-preview-669--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax changed the title feat(SegmentList): add opacity slider for selected segment Segments: opacity slider and visibile toggle Oct 17, 2024
@PaulHax PaulHax requested a review from floryst October 17, 2024 21:48
@PaulHax PaulHax force-pushed the segment-opacity branch 2 times, most recently from 93e349a to 4cd5284 Compare October 21, 2024 17:55
… logic

Rename functions using labelMap to segmentGroup
Copy link
Contributor

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one unused import comment.

I re-ran the test in case it's transient, but if it fails again we'll take a look.

import { FileEntry } from '../io/types';
import { ensureSameSpace } from '../io/resample/resample';
import { useDICOMStore } from './datasets-dicom';
import { vi } from 'vitest';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it!

@PaulHax
Copy link
Collaborator Author

PaulHax commented Oct 23, 2024

Yes, the e2e layer test got flakey on ubuntu couple weeks ago.

@PaulHax PaulHax added this pull request to the merge queue Oct 23, 2024
Merged via the queue into Kitware:main with commit 80021a2 Oct 23, 2024
PaulHax added a commit to PaulHax/VolView that referenced this pull request Apr 24, 2025
Segments:  opacity slider and visibile toggle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants