fix(updateFileMimeType): overwrite mimetype#664
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulHax
approved these changes
Oct 15, 2024
Collaborator
PaulHax
left a comment
PaulHax
left a comment
There was a problem hiding this comment.
I can't think of anything this would break.
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
fix(updateFileMimeType): overwrite mimetype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #663, and maybe #655.
Overwrites/normalizes the default OS-provided mimetype. Also ensures that the mime type is a supported mime type.
@PaulHax I think this should be fine, since if it's an unsupported mime type, setting to "null" won't change any logic.
Should also be applied here: https://github.com/Kitware/VolView/pull/635/files#diff-7d267f00b6c6e1caa0952df237d876fce197c2048228c5f5bda7dd583232a40eR10