fix(VolumeRendering): on switching dataset, ensure CTF preset valid#656
Merged
floryst merged 1 commit intoKitware:mainfrom Oct 2, 2024
Merged
fix(VolumeRendering): on switching dataset, ensure CTF preset valid#656floryst merged 1 commit intoKitware:mainfrom
floryst merged 1 commit intoKitware:mainfrom
Conversation
Bug reproduction steps: 1. Load prostate sample 2. Switch to Rendering tab 3. Load Fetus sample Error: VolumeRendering component would get an empty string preset, then fail to get a color transfer function from that. This change initializes the volume-coloring store for a dataset in all components that depend on volume-coloring.
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
floryst
approved these changes
Oct 2, 2024
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
fix(VolumeRendering): on switching dataset, ensure CTF preset valid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug reproduction steps:
Error: VolumeRendering component would get an empty string preset, then fail to get a color transfer function from that.
This change initializes the volume-coloring store for a dataset in all components that depend on volume-coloring.