Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulHax
approved these changes
May 20, 2024
Volume keys are now used as image data IDs. This simplifies going back and forth between the image and dicom store, and simplifies the structure of the selection object to be just an ID string.
Contributor
Author
We can figure out a migration layer later if this becomes a major issue. For now, I've bumped the manifest major version. |
Collaborator
|
When/if we get a complaint, we have some migrate code here: VolView/src/io/import/processors/restoreStateFile.ts Lines 114 to 162 in a7b6290 |
1isten
added a commit
to 1isten/VolView
that referenced
this pull request
Jun 1, 2024
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
feat: unify data IDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volume keys are now used as image data IDs. This simplifies going back and forth between the image and dicom store, and simplifies the structure of the selection object to be just an ID string.
This doesn't address migration of older session files. That is a nice-to-have, but we don't have a good way of handling migrations at the moment. @PaulHax if this breaks stored session files, then I'll add a migration path.