Segment group file format selection for serialization #527
Segment group file format selection for serialization #527PaulHax merged 5 commits intoKitware:mainfrom
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulHax
force-pushed
the
export-segment-group
branch
from
6286cb4 to
97257f2
Compare
PaulHax
changed the title
PaulHax
force-pushed
the
export-segment-group
branch
from
97257f2 to
e2a0984
Compare
PaulHax
force-pushed
the
export-segment-group
branch
from
e2a0984 to
df5e8f1
Compare
jadh4v
left a comment
jadh4v
left a comment
There was a problem hiding this comment.
I am wondering if there's going to be a conflict in the future regarding the segmentation information that is stored in the session's json file vs the embedded info stored inside .nrrd and other fancier file formats that we might support in the future.
PaulHax
force-pushed
the
export-segment-group
branch
from
4345276 to
a2634a7
Compare
|
This is good to go by me. Followup PR for GUI export button. |
PaulHax
force-pushed
the
export-segment-group
branch
from
0df0301 to
94693c9
Compare
jadh4v
left a comment
jadh4v
left a comment
There was a problem hiding this comment.
LGTM, apart from a few general comments.
| import { FileReaderMap } from '.'; | ||
|
|
||
| import { readFileAsArrayBuffer } from './io'; | ||
| import { stlReader, vtiReader, vtpReader } from './vtk/async'; |
There was a problem hiding this comment.
Looks like itk-wasm/mesh-io also has a similar generic reader for polydata? Maybe in the future we could get rid of these special readers as well.
There was a problem hiding this comment.
Yes, cool. VolView's mesh support is just vestigial at the moment.
| state: 'Done', | ||
| }; | ||
| } catch (error) { | ||
| console.error(error); |
There was a problem hiding this comment.
Do you want to keep this, or was just added during debugging?
There was a problem hiding this comment.
Good check, did want to keep actualy.
Add segmentGroupSaveFormat section.
PaulHax
force-pushed
the
export-segment-group
branch
from
55cb8a3 to
67d2631
Compare
floryst
left a comment
floryst
left a comment
There was a problem hiding this comment.
LGTM. Haven't tested functionality yet.
Segment group file format selection for serialization
3 participants
VolView will save "segment group" images into a file format configurable by a config.JSON file.
deserializewill read whatever format it finds in the .zip file.This is the config json to change the saved format
To test: Can drag and drop this config file on VolView before saving.
config-save-format.json
Possible formats here:
https://github.com/InsightSoftwareConsortium/itk-wasm/blob/main/packages/image-io/typescript/src/extension-to-image-io.ts
TODO
- [ ] Add GUI to set format, maybeFollow up PR to add GUI.