Skip to content

Generate notification error when up bad URL in remoteManfest.json files#489

Merged
floryst merged 2 commits intoKitware:mainfrom
PaulHax:remote-manifest-download
Nov 9, 2023
Merged

Generate notification error when up bad URL in remoteManfest.json files#489
floryst merged 2 commits intoKitware:mainfrom
PaulHax:remote-manifest-download

Conversation

@PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Nov 7, 2023

  • Add test expecting error notification if URL in remoteManifest.json is not a URL
  • If there is a bad URL in remoteManifest.json, the datasource is passed down the Pipeline. Changed importDataSources handleConfig to pass through a JSON file that has no known "config" keys. Then unhandledResource will generate an error.

@netlify
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b8a383b
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/654ce8e9c745dc00089e63c9
😎 Deploy Preview https://deploy-preview-489--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax changed the title chore(remote-manifest.e2e): Bubble up bad URL exception in remoteManfest.json files Nov 7, 2023
@PaulHax PaulHax changed the title Bubble up bad URL exception in remoteManfest.json files Generate notification error when up bad URL in remoteManfest.json files Nov 8, 2023
@PaulHax PaulHax marked this pull request as ready for review November 8, 2023 21:47
@PaulHax PaulHax requested a review from floryst November 8, 2023 21:48
@floryst
Copy link
Contributor

floryst commented Nov 9, 2023

LGTM!

@floryst floryst added this pull request to the merge queue Nov 9, 2023
Merged via the queue into Kitware:main with commit 7db5959 Nov 9, 2023
PaulHax pushed a commit to PaulHax/VolView that referenced this pull request Apr 24, 2025
Generate notification error when up bad URL in remoteManfest.json files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants