fix(annotation-tools): handle radius too small with devicePixelRatio#451
Merged
floryst merged 2 commits intoKitware:mainfrom Oct 10, 2023
PaulHax:handle-dpr
Merged
fix(annotation-tools): handle radius too small with devicePixelRatio#451floryst merged 2 commits intoKitware:mainfrom PaulHax:handle-dpr
floryst merged 2 commits intoKitware:mainfrom
PaulHax:handle-dpr
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
LGTM overall. I think we should reduce the handle size by half since the handles are now much larger than before. |
Collaborator
Author
|
No strong opinion on handle size. If reduced, they would get smaller for us devicePixelRatio 1 peeps. Let us keep the 3D handle size the same, and just reduce the visual circle size. That would be like the behavior before for when devicePixelRatio = 2 |
Contributor
|
Thanks for the clarification, I did mean the visual handle size. The pickable handle size can remain the same. |
Collaborator
Author
|
Reduced visual handle size to 6 CSS pixels.
|
No need to scale SVG circle radius by devicePixelRatio.
Contributor
|
LGTM |
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
fix(annotation-tools): handle radius too small with devicePixelRatio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to scale SVG circle radius by devicePixelRatio.
Before with devicePixelRatio 1
Before with devicePixelRatio 2
After with devicePixelRatio 1
After with devicePixelRatio 2
