Conversation
The per-tool nominal types weren't proving useful. We now unify all tools to use the same ToolID type.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulHax
approved these changes
Sep 20, 2023
Collaborator
PaulHax
left a comment
PaulHax
left a comment
There was a problem hiding this comment.
I guess TS does not have to be bunch of type gymnastics. Enough of a workout in other ways.
Contributor
Author
|
Certainly so. It's a good idea if we needed compile-and-IDE-time hints that we are using an improper ID, but turns out we never ran into that so far. |
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
refactor: drop tool-specific ID types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-tool nominal types weren't proving useful. We now unify all tools to use the same ToolID type.