Merged
Conversation
Contributor
floryst
commented
Sep 15, 2023
- Some code refactoring for easier usage
- useFrameOfReference encapsulates the frame of reference handling
- usePlacingAnnotationTool provides a more readable API for managing the placing tool
- added finishedTools to all annotation tools
- simplified the point visibility code to make it more obvious as to what it's doing
- removed the movePoint state from the polygon store
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
I've decided against making one giant composable for the Tool and Widget components. I think it's an unnecessary abstraction to deal with for now if the only goal is code deduplication. Maybe we can revisit it once we've added more tools, as reducing the bundle size may become a driving reason. My primary goal is to ensure readability of the tool logic while keeping flexibility. |
PaulHax
reviewed
Sep 15, 2023
Collaborator
PaulHax
left a comment
There was a problem hiding this comment.
Good cleanup. Small bug then good by me.
Collaborator
|
Guess we should remove this too https://github.com/Kitware/VolView/blob/main/src/types/polygon.ts#L11 |
Contributor
Author
|
Updated to address comments. |
This state should not be stored inside the tool.
419d964 to
45be61a
Compare
This was referenced Sep 18, 2023
Closed
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
Simplify tool code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.