feat(DataBrowser): hide Sample Data if configured#381
Merged
floryst merged 1 commit intoKitware:mainfrom Aug 1, 2023
PaulHax:hide-samples
Merged
feat(DataBrowser): hide Sample Data if configured#381floryst merged 1 commit intoKitware:mainfrom PaulHax:hide-samples
floryst merged 1 commit intoKitware:mainfrom
PaulHax:hide-samples
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
floryst
reviewed
Jul 31, 2023
Contributor
floryst
left a comment
floryst
left a comment
There was a problem hiding this comment.
What do you think about adding an empty state for the sidebar if there are no panels? Something that says "No data loaded". There should be a CSS way to detect this.
I'm okay with the extra store, since it keeps with the idea that the UI should be driven by the stores.
Collaborator
Author
|
Added the "No data loaded" message. |
Contributor
|
LGTM! |
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
feat(DataBrowser): hide Sample Data if configured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind of silly to make a new store just for this? 🤷 Simpler way?
Closes #380