Data privacy and security handling updates#367
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
floryst
force-pushed
the
proposal/data-security-more-info
branch
2 times, most recently
from
47dcb51 to
c1ccdc5
Compare
Contributor
|
Great start! I like the position and the look-and-feel. Regarding the text, I like the organization. We should tweak the wording a bit (particularly with the development of a python server). Also, let's turn off analytics and work with sysadmin to simply get a count of number of visitors to the weblink..
If you would like to opt-out of error reporting, you may turn it off using the following setting. Your choice will be respected for future VolView sessions that you run on this machine. |
- better sentry tree-shaking - toggle sentry enable/disable state - remove session replay and performance tracking - indicate if error reporting is turned off at build time
floryst
force-pushed
the
proposal/data-security-more-info
branch
from
c1ccdc5 to
8847ed8
Compare
floryst
changed the title
floryst
changed the title
floryst
changed the title
Contributor
Author
|
I've updated my PR description with the new changes. Since I don't add sentry env vars to deploy previews, error reporting cannot be triggered. If sentry is enabled, the data privacy & security dialog adds the following bit to the bottom: |
- Configure site via env var - Add host and path to the path parameter, so we can identify whether the hit is from the stable or main deployments.
floryst
force-pushed
the
proposal/data-security-more-info
branch
from
233e612 to
f0fd74c
Compare
Contributor
|
LGTM! |
aylward
approved these changes
Jul 21, 2023
PaulHax
approved these changes
Jul 21, 2023
Collaborator
PaulHax
left a comment
PaulHax
left a comment
There was a problem hiding this comment.
Works good!
I like the purple, but other buttons and toggles are different colors. Should probably use just the Kitware blue or green as our accent someday.
Contributor
Author
|
I switched the toggle and "learn more" button to use the secondary color, similar to what the settings toggles use. |
floryst
force-pushed
the
proposal/data-security-more-info
branch
from
bb22b00 to
108033b
Compare
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
…re-info Data privacy and security handling updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.