More label fixes

[floryst]

Fixes the types passed into useLabels.

[netlify]

✅ Deploy Preview for volview-dev ready!

Name	Link
🔨 Latest commit	5cf8007
🔍 Latest deploy log	https://app.netlify.com/sites/volview-dev/deploys/64aee05346f3bb0008c02253
😎 Deploy Preview	https://deploy-preview-366--volview-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[PaulHax]

We lost some type safety with the MakeToolDefaults extends (...args: any) => any change earlier. Before, ToolDefaults and label properties needed to exist in the Ruler or Rectangle type.

Would be nice if we got a Typescript error if default label properties did not exist on tool. Then a object of type Label<Tool> could not have arbitrary properties.

[floryst]

I'm not sure if we've lost type safety. We have type ToolDefaults = ReturnType<MakeToolDefaults>, which infers the return type of the passed-in toolDefaults function.

I find Label<Tool> to be misleading. A label doesn't need to follow the Tool & AnnotationTool type. AFAIK it should be { labelName: string } & typeof newLabelDefault. I was seeing toolStore.labels[labelId] contain properties from AnnotationTool, which seems incorrect.

If there's something design-wise that I missed, do let me know.

[PaulHax]

Ah, I see, thanks for the learning.