Tool Labels: Add, Edit, Delete#358
Merged
floryst merged 23 commits intoKitware:mainfrom Jul 6, 2023
PaulHax:label-crud
Merged
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
With generated IDs, label name is no longer the key. This allows for easy editing of label names just like other label props.
So keys q and w don't change selected label
Avoids duplicate labels after saving a session with configured labels, then loading the session with configured labels still.
PaulHax
commented
Jun 27, 2023
PaulHax
commented
Jun 27, 2023
Fixes placing tool keeping existing label fillColor after creating new label.
floryst
reviewed
Jun 28, 2023
Contributor
|
Some UI suggestions:
|
* No outline on edit label button
Collaborator
Author
Good tips. I removed the outline on the edit label button, added a "close" button, and introduced some white space to edit label module. |
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
Tool Labels: Add, Edit, Delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds edit label and add label buttons to label list card:

Clicking the pencil button pops a modal:

closes #347