Skip to content

Tool Labels: Add, Edit, Delete#358

Merged
floryst merged 23 commits intoKitware:mainfrom
PaulHax:label-crud
Jul 6, 2023
Merged

Tool Labels: Add, Edit, Delete#358
floryst merged 23 commits intoKitware:mainfrom
PaulHax:label-crud

Conversation

@PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Jun 27, 2023

Adds edit label and add label buttons to label list card:
image

Clicking the pencil button pops a modal:
image

closes #347

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 04ea90a
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/649f3f72bbb45d0008bffd78
😎 Deploy Preview https://deploy-preview-358--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax changed the title Labels: Add, Edit, Delete Annotation Labels: Add, Edit, Delete Jun 27, 2023
@PaulHax PaulHax changed the title Annotation Labels: Add, Edit, Delete Tool Labels: Add, Edit, Delete Jun 27, 2023
@PaulHax PaulHax marked this pull request as ready for review June 27, 2023 19:05
@PaulHax PaulHax requested a review from floryst June 27, 2023 19:05
@floryst
Copy link
Contributor

floryst commented Jun 30, 2023

Some UI suggestions:

  • I think the edit button background doesn't look great given that it intersects with the label border. Lets try either removing the button background altogether or introduce a small gap between the button and the label border.
  • I think we should have a "save/done" button in the label editor, even though all changes persist immediately. Not all users will understand that changes are auto-saved. Side-note: we may need to add a "cancel" button if users would rather changes not persist immediately, but I don't think we should handle that case right now.
  • I think we may re-examine the layout of the label editor down the road. I like how it is currently because it allows for more fields in the future, but something still feels off. Maybe it's the lack of margins around the color picker and the text editor.

* No outline on edit label button
@PaulHax
Copy link
Collaborator Author

PaulHax commented Jun 30, 2023

Some UI suggestions:

Good tips. I removed the outline on the edit label button, added a "close" button, and introduced some white space to edit label module.

Copy link
Contributor

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@floryst floryst merged commit d9033a2 into Kitware:main Jul 6, 2023
PaulHax pushed a commit to PaulHax/VolView that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annotation Tool Labels: Create, Edit, Delete

2 participants