Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
|
This actually needs a bit more work to get unit tests back. |
Contributor
Author
|
I've removed unit testing for now. I'll follow up with a new PR for testing to avoid mixing things up, since I want to enable running unit tests in CI. This is ready now. |
Dropping test:unit until we get vitest integrated.
Contributor
Author
|
This also changes the default colormap to CT-AAA (@aylward), since I'm opting to not bring in the vtk.js colormaps as we don't use any of them, and "Cool to Warm" seems like a bad default. |
PaulHax
approved these changes
Jun 16, 2023
Collaborator
PaulHax
left a comment
PaulHax
left a comment
There was a problem hiding this comment.
Verks good. Key step in devops journey.
PaulHax
pushed a commit
to PaulHax/VolView
that referenced
this pull request
Apr 24, 2025
Migrate to vite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add unit test runner