Volume quality slider by sankhesh · Pull Request #283 · Kitware/VolView

sankhesh · 2023-02-14T14:43:52Z

netlify · 2023-02-14T14:43:59Z

✅ Deploy Preview for volview ready!

Name	Link
🔨 Latest commit	`e5d11d5`
🔍 Latest deploy log	https://app.netlify.com/sites/volview/deploys/63eb9ed6df518a0008d25ec8
😎 Deploy Preview	https://deploy-preview-283--volview.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sankhesh · 2023-02-14T14:45:21Z

@aylward PTAL

aylward · 2023-02-14T23:15:51Z

Looks great! The slider has a noticeable impact - but is there a way to increase realism even further when the maximum quality is selected? On my old system, it is still quite fast on the maximum quality setting - and at that setting we can definitely take more time to do renderings if the quality can be improved.

src/components/VtkThreeView.vue

src/components/VolumeProperties.vue

src/store/view-configs/volume-coloring.ts

src/components/VtkThreeView.vue

netlify · 2023-04-16T04:33:48Z

✅ Deploy Preview for volview-dev ready!

Name	Link
🔨 Latest commit	`8b0900f`
🔍 Latest deploy log	https://app.netlify.com/sites/volview-dev/deploys/643eb817edcd0100086c7d06
😎 Deploy Preview	https://deploy-preview-283--volview-dev.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

aylward · 2023-04-16T11:22:33Z

Absolutely beautiful! And stable on my phone!

sankhesh · 2023-04-17T14:52:16Z

@aylward What do you think? -

aylward · 2023-04-17T17:58:01Z

Thinking about this - I don't think the quality is ever "low"

How about
Good - Better - Ultra - Experimental

One issue also is that there isn't much (enough) space between Ultra and Experimental in the about figure - looks like one label "Ultra Experimental"

Perhaps change Experimental to Beta?

Good - Better - Ultra - Beta

?

sankhesh · 2023-04-18T01:45:55Z

@aylward Good to merge?

aylward

Looks great!!!!

Perhaps the "Don't show again" button could be shown in a different color or have a stronger outline around the button? It is a little hard to tell it is a button on my display.

src/components/VolumeProperties.vue

floryst · 2023-04-18T15:34:48Z

src/components/VolumeProperties.vue

+    const lightingModel = ref<keyof typeof LIGHTING_MODELS>('hybrid');
+    const selectLightingMode = (buttonTxt: string) => {


Here is a stronger and more succinct typing for selectLightingMode:

Suggested change

const lightingModel = ref<keyof typeof LIGHTING_MODELS>('hybrid');

const selectLightingMode = (buttonTxt: string) => {

type LightingModel = keyof typeof LIGHTING_MODELS;

const lightingModel = ref<LightingModel>('hybrid');

const selectLightingMode = (buttonTxt: LightingModel) => {

floryst · 2023-04-18T19:05:46Z

Here is an idea I think would be good to have, but we can do this after this PR is merged: we can have a question mark icon that, when clicked, goes to a page in our documentation that explains what it means when we way "Ultra / Beta is unstable on some systems".

aylward · 2023-04-18T19:08:58Z

Great idea! s

…

On Tue, Apr 18, 2023 at 3:05 PM Forrest Li ***@***.***> wrote: Here is an idea I think would be good to have, but we can do this after this PR is merged: we can have a question mark icon that, when clicked, goes to a page in our documentation that explains what it means when we way "Ultra / Beta is unstable on some systems". — Reply to this email directly, view it on GitHub <#283 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACEJLYJWQTJOPD75H6X4IDXB3QZLANCNFSM6AAAAAAU3U2DBU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Stephen R. Aylward, Ph.D. Senior Director of Strategic Initiatives Chair of MONAI Advisory Board --- Kitware: *Delivering innovation.*

sankhesh · 2023-04-19T12:19:56Z

@floryst @aylward How do I bypass the merge queue? I just a see a button Merge when ready and it keeps waiting for the two jobs that don't have anything to do.

floryst · 2023-04-19T12:51:14Z

I just enabled merge queues in VolView to trial this feature. I think it's not fully set up yet. I'll handle it.

Volume quality slider

sankhesh force-pushed the volume_quality_slider branch from 6bb070f to f796fb4 Compare February 14, 2023 14:44

sankhesh force-pushed the volume_quality_slider branch from f796fb4 to e5d11d5 Compare February 14, 2023 14:46

PaulHax reviewed Feb 15, 2023

View reviewed changes

src/components/VtkThreeView.vue Show resolved Hide resolved

floryst reviewed Feb 15, 2023

View reviewed changes

src/components/VolumeProperties.vue Outdated Show resolved Hide resolved

floryst linked an issue Feb 22, 2023 that may be closed by this pull request

3D sample distance slider #277

Closed

aylward suggested changes Mar 6, 2023

View reviewed changes

src/store/view-configs/volume-coloring.ts Outdated Show resolved Hide resolved

src/components/VtkThreeView.vue Show resolved Hide resolved

sankhesh added 9 commits April 14, 2023 11:35

feat(LAO): Common LAO toggle for standard and hybrid lighting models

cafedca

feat(vtk-js): Update vtk-js to v27.1.2

a78c935

feat(3Dview): Implement a volume viz quality slider

ba568d3

feat(rendering): Volume sampling slider support in the visualization

3cd574f

feat(VtkThreeView): Change the default quality

1b65ca6

fix(VolumeProperties): Maximum diffuse value should be 1.0

adeaac0

feat(VolumeProperties): Warning popup on higher quality values

bb8100d

feat(VolumeProperties): Add a tooltip for the warning actions

c1770bd

feat(VtkThreeView): Tweak volume quality settings

f112453

sankhesh force-pushed the volume_quality_slider branch from e5d11d5 to f112453 Compare April 16, 2023 04:33

aylward approved these changes Apr 16, 2023

View reviewed changes

reformat(Volume): Reformat using prettier

723ec4c

sankhesh mentioned this pull request Apr 17, 2023

Volume LAO toggle #304

Closed

sankhesh force-pushed the volume_quality_slider branch from 8cf0f63 to ef58654 Compare April 17, 2023 15:57

sankhesh force-pushed the volume_quality_slider branch from ef58654 to 9c07a31 Compare April 17, 2023 22:47

aylward approved these changes Apr 18, 2023

View reviewed changes

floryst reviewed Apr 18, 2023

View reviewed changes

src/components/VolumeProperties.vue Outdated Show resolved Hide resolved

src/components/VolumeProperties.vue Outdated Show resolved Hide resolved

sankhesh added 3 commits April 18, 2023 11:14

refactor(QualitySlider): Modify labels and warning

eacf745

feat(VolumeRendering): Hybrid lighting mode by default

a7a4bec

Merge branch 'main' into volume_quality_slider

35a0502

sankhesh force-pushed the volume_quality_slider branch from 0455edb to 35a0502 Compare April 18, 2023 15:20

refactor(LightingMode): Switch to key references for lighting mode

8b0900f

sankhesh force-pushed the volume_quality_slider branch from 20782e4 to 8b0900f Compare April 18, 2023 15:32

floryst reviewed Apr 18, 2023

View reviewed changes

floryst mentioned this pull request Apr 18, 2023

Add a link to docs regarding potential instability of max quality rendering settings #309

Open

sankhesh added this pull request to the merge queue Apr 19, 2023

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 19, 2023

floryst added this pull request to the merge queue Apr 19, 2023

Merged via the queue into Kitware:main with commit 71d69c5 Apr 19, 2023

PaulHax pushed a commit to PaulHax/VolView that referenced this pull request Apr 24, 2025

Merge pull request Kitware#283 from sankhesh/volume_quality_slider

5e39ae6

Volume quality slider

		const lightingModel = ref<keyof typeof LIGHTING_MODELS>('hybrid');
		const selectLightingMode = (buttonTxt: string) => {

-    const lightingModel = ref<keyof typeof LIGHTING_MODELS>('hybrid');
-    const selectLightingMode = (buttonTxt: string) => {
+    type LightingModel = keyof typeof LIGHTING_MODELS;
+    const lightingModel = ref<LightingModel>('hybrid');
+    const selectLightingMode = (buttonTxt: LightingModel) => {

Conversation

sankhesh commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for volview ready!

Uh oh!

sankhesh commented Feb 14, 2023

Uh oh!

aylward commented Feb 14, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for volview-dev ready!

Uh oh!

aylward commented Apr 16, 2023

Uh oh!

sankhesh commented Apr 17, 2023

Uh oh!

aylward commented Apr 17, 2023

Uh oh!

sankhesh commented Apr 18, 2023

Uh oh!

aylward left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

floryst Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

floryst commented Apr 18, 2023

Uh oh!

aylward commented Apr 18, 2023 via email

Uh oh!

Uh oh!

sankhesh commented Apr 19, 2023

Uh oh!

floryst commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sankhesh commented Feb 14, 2023 •

edited

Loading

netlify bot commented Feb 14, 2023 •

edited

Loading

netlify bot commented Apr 16, 2023 •

edited

Loading

aylward left a comment •

edited

Loading