fix(dev-cli): include prereq checks in envCheck allGood flag

[evan-claw]

Problem

The envCheck function in dev/cli/src/commands/env.ts displays a false-positive success banner.

allGood is initialized to true (line 27) and only set to false inside the per-service for loop (lines 39, 49). The two prerequisite checks — .env.local existence and .vercel/project.json existence — print errors/warnings but never flip allGood to false.

Proof the issue is real

When .env.local is missing, the function:

1. Prints ✗ .env.local missing — run: vercel env pull via ui.error()
2. Proceeds through the service loop (which may find everything OK)
3. Reaches allGood === true and prints All environment checks passed!

Same for .vercel/project.json: ui.warn() fires but allGood stays true.

The new tests confirm this — they fail on the original code (3/4 fail) and pass on the fixed code (4/4 pass).

Proof this is not a band-aid

The root cause is in envCheck itself: allGood is declared after the prereq checks and doesn't incorporate their results. There is no upstream caller or data source that should be responsible for this — the function owns both the checks and the banner, so the fix belongs here.

What changed

dev/cli/src/commands/env.ts: Changed let allGood = true → let allGood = envLocalExists && vercelLinked, moved before the services filter. This ensures the final banner reflects all checks, not just the service loop.

dev/cli/test/env-check.test.ts: Added 4 integration tests that run envCheck against a temp directory tree with controlled filesystem state:

1. Missing .env.local → banner says "needs attention" (not "passed")
2. Missing .vercel/project.json → banner says "needs attention"
3. Both missing → banner says "needs attention"
4. All present + services OK → banner says "passed"

All 19 tests pass (15 existing + 4 new).

Fixes review comment: #1142 (comment)

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

• dev/cli/src/commands/env.ts
• dev/cli/test/env-check.test.ts

---

_{Reviewed by gpt-5.4-20260305 · 133,279 tokens}