refactor(models): remove deprecatedAutoModelsToPreventNewExtensionModelPickerFromGettingStuck#1273
refactor(models): remove deprecatedAutoModelsToPreventNewExtensionModelPickerFromGettingStuck#1273kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
…elPickerFromGettingStuck
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)None. Files Reviewed (3 files)
Reviewed by gpt-5.4-20260305 · 185,180 tokens |
|
|
||
| // Legacy aliases so persisted model selections (e.g. in app-builder projects) remain valid | ||
| const legacyAliases = Object.entries(legacyAutoModelMapping).flatMap(([legacyId, model]) => | ||
| model ? [{ ...model, id: legacyId }] : [] |
There was a problem hiding this comment.
WARNING: Legacy aliases are no longer marked as deprecated
legacyAliases clones the canonical model name and description, so /api/openrouter/models now contains two indistinguishable "Kilo Auto Frontier/Free/Small" entries: the real kilo-auto/* IDs and the legacy kilo/auto* IDs. Any picker that renders name now offers deprecated IDs as if they were current options, which undermines the migration path and can create duplicate-looking rows. Keep serving the aliases for persisted selections, but preserve a deprecated label/description or otherwise hide them from new selections.
chrarnoldus
force-pushed
the
remove-deprecated-auto-models-function
branch
from
baafa24 to
247eaf5
Compare
2 participants
Summary
Removes the
deprecatedAutoModelsToPreventNewExtensionModelPickerFromGettingStuckfunction and its sole callsite inbuildAutoModels. The deprecated model entries (kilo/auto,kilo/auto-free,kilo/auto-small) are no longer injected into the model list returned to clients. The approval snapshot is updated accordingly.Verification
src/lib/providers/openrouter/index.ts), no other consumers.openrouter-models-sorting.approved.jsonand fixed trailing comma.node_modulesnot available in this environment; no automated test run was possible.Visual Changes
N/A
Reviewer Notes
The
legacyMappinginkilo-auto-model.tsis still used byisKiloAutoModelandresolveAutoModel, so it is intentionally left in place — only the function that generated deprecated phantom model-picker entries is removed.