This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Fix diff? method for newer JunOS versions#58
Merged
ydnath merged 1 commit intoJuniper:masterfrom Apr 13, 2018
Merged
Conversation
vnitinv
reviewed
Apr 6, 2018
| def diff?( rollback_id = 0 ) | ||
| raise ArgumentError, "invalid rollback #{rollback_id}" unless ( rollback_id >= 0 and rollback_id <= 50 ) | ||
| got = ndev.rpc.get_configuration( :compare=>'rollback', :rollback=> rollback_id.to_s ) | ||
| got = ndev.rpc.get_configuration( :compare => 'rollback', :rollback => rollback_id.to_s, :format => 'text' ) |
Contributor
Member
|
Checked and does not impact north bound api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue getting the
diff?from a switch when there are no changes to be commited.On JunOS ~14,
ndev.rpc.get_configuration( :compare=>'rollback', :rollback=> rollback_id.to_s )returns an xml response:But on JunOS ~17, the same method call, returns
nilmaking the subsequent line to fail withundefined method 'xpath' for nil:NilClassAdding
:format => 'text'to the call seems to make the behavior consistent across different JunOS versionsPS: I took the idea from the more up to date python library https://github.com/Juniper/py-junos-eznc/blob/ce914d19030f51067b0c02c72fd69557f26c49e9/lib/jnpr/junos/utils/config.py#L225