Restrict StaticArrays to compatible versions#688
Merged
andreasnoack merged 5 commits intomasterfrom Mar 7, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #688 +/- ##
==========================================
- Coverage 89.65% 89.57% -0.09%
==========================================
Files 11 11
Lines 967 969 +2
==========================================
+ Hits 867 868 +1
- Misses 100 101 +1 ☔ View full report in Codecov by Sentry. |
andreasnoack
force-pushed
the
an/staticarrays
branch
3 times, most recently
from
fc299e6 to
e321f97
Compare
devmotion
reviewed
Mar 7, 2024
andreasnoack
force-pushed
the
an/staticarrays
branch
from
09ce8d0 to
e03a03a
Compare
andreasnoack
force-pushed
the
an/staticarrays
branch
from
e03a03a to
8279653
Compare
devmotion
approved these changes
Mar 7, 2024
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
LGTM (I'm fine with fixing the remaining allocation tests in a separate PR).
andreasnoack
force-pushed
the
an/staticarrays
branch
from
156fd64 to
6b5ed48
Compare
Member
Author
|
@devmotion I've also disabled testing on nightly. There is a failure similarly to the one that was fixed in 1.10 by capping StaticArrays. I've also marked two of the allocation tests as broken. |
devmotion
approved these changes
Mar 7, 2024
devmotion
pushed a commit
that referenced
this pull request
Sep 30, 2024
devmotion
pushed a commit
that referenced
this pull request
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like version 1.7 broke the eigen definition here so until it has been fixed, the bounds would have to be restricted.