Conversation
Member
Author
|
Restarted Travis now that Calculus has been freshly tagged, hopefully things should pass now. |
Contributor
|
If these higher minimum versions are only needed for the tests to pass here on 0.6, then they're too tight and you're ruling out package version combinations that do work correctly together on 0.4 and 0.5. If you want tighter 0.6-specific bounds you should do so by tagging from a separate 0.6-only branch. |
tkelman
added a commit
to tkelman/ForwardDiff.jl
that referenced
this pull request
Mar 17, 2017
… to include v0.6 fixes (JuliaDiff#184)" This reverts commit 62ad04b. If higher minimum versions are only needed for 0.6, they should be loosened here Upper bound this branch so it is not installable on 0.6.
jrevels
pushed a commit
that referenced
this pull request
Mar 21, 2017
…205) * Revert "bump version requirements for Calculus, DiffBase, and NaNMath to include v0.6 fixes (#184)" This reverts commit 62ad04b. If higher minimum versions are only needed for 0.6, they should be loosened here Upper bound this branch so it is not installable on 0.6. * fix seed-reset order for no-op cases where input === the output (#204) (cherry picked from commit 6c61b61) * don't test this branch on nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on JuliaLang/METADATA.jl#7645 getting merged. I plan on tagging a new patch release of ForwardDiff once this is merged.