Skip to content

Conversation

@c-dilks
Copy link
Member

@c-dilks c-dilks commented Apr 11, 2025

@gavalian says it's too small; this is for testing a high-stats run in clas12-validation with larger max heap size.

c-dilks added a commit to JeffersonLab/clas12-validation that referenced this pull request Apr 11, 2025
@c-dilks
Copy link
Member Author

c-dilks commented Apr 11, 2025

testing with JeffersonLab/clas12-validation#177

we know 1500m fails because JeffersonLab/clas12-validation#172

@c-dilks
Copy link
Member Author

c-dilks commented Apr 14, 2025

allocating 3GB speeds clas12-validation reconstruction up quite a bit: JeffersonLab/clas12-validation#177

So.... let's make heap allocation control a feature, and leave the default the same.

@c-dilks c-dilks changed the title test: increase max heap size for recon-util feat: heap size control for recon-util Apr 14, 2025
@c-dilks c-dilks marked this pull request as ready for review April 14, 2025 22:22
@c-dilks c-dilks requested a review from baltzell April 14, 2025 22:22
c-dilks added 2 commits April 24, 2025 12:20
@gavalian says it's too small; this is for testing a high-stats run in
`clas12-validation`
@baltzell
Copy link
Collaborator

baltzell commented May 1, 2025

Let's pursue a more generic approach that supports passing any arbitrary JVM options, for all these frontend scripts. Could push it to OptionParser, or use the old-school -- separator for CLI arguments in the shell wrapers, or ....

See #604

@c-dilks
Copy link
Member Author

c-dilks commented May 1, 2025

Let's pursue a more generic approach that supports passing any arbitrary JVM options, for all these frontend scripts. Could push it to OptionParser, or use the old-school -- separator for CLI arguments in the shell wrapers, or ....

See #604

Fully agree, as discussed. Comment linked to #604 description.

@c-dilks c-dilks closed this May 1, 2025
@c-dilks c-dilks deleted the heeeeep branch May 1, 2025 15:58
c-dilks added a commit to JeffersonLab/clas12-validation that referenced this pull request May 8, 2025
c-dilks added a commit to JeffersonLab/clas12-validation that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants