Draft
Conversation
added 2 commits
April 27, 2020 15:49
This commit switched the cache to using a flat layout for Elements; instead of storing the Elements in a linked list, it stores them in a slice, and stores indexes into the slice where it once stored pointers. This has two advantages: 1. The resulting code is slightly smaller. 2. It has better locality One issue the linked list version could have is that after extensive deletions and additions, the Elements could be scattered across memory. By storing the elements in slices, and reusing the slots when elements are removed, all the elements should remain close together. This strategy has the disadvantage in that it might make eviction slower; it depends on if the better locality or the number of elements to check is the dominant term.
Besides adding more comments, this commit adds the ability to store string values within the cache. We do this by just adding a str_value to the Element struct; this doesn't take any additional space, since we needed to pad out that struct to be cache-aligned anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.