[MOB-10804] Rework append for better memory efficiency#56
Closed
MiguelAMarcelino wants to merge 1 commit intomasterfrom
Closed
[MOB-10804] Rework append for better memory efficiency#56MiguelAMarcelino wants to merge 1 commit intomasterfrom
MiguelAMarcelino wants to merge 1 commit intomasterfrom
Conversation
81a365f to
493047d
Compare
Author
|
Closing. This has been merged on the official handlebars repo. Now its a matter of synching both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporating changes submitted on this PR: jknack#1156
Trying to optimize the append method to improve memory efficiency and reduce object allocations. Previously, the code relied on the
textWithoutEscapeCharmethod, which involved converting the internalStringBuilderto aStringand then to achar[]. My goal here is to reduce unnecessary intermediate allocations and processing overhead.Changes Introduced
textWithoutEscapeCharto avoid the conversion chain (StringBuilder→String→char[]).Alternative Consideration:
An alternative approach considered was to rewrite the
textWithoutEscapeCharmethod for better performance. The revised method would look like this:This version avoids converting the
StringBuilderto aStringand directly copies the characters into achar[], reducing unnecessary overhead.Future Enhancements:
There is a potential case to investigate the frequent resizing of the
StringBuilderused inText. Pre-sizing theStringBuilderto an appropriate capacity may further improve performance and memory usage.