make array Hermitian before calling complex-to-real FFT#2444
Merged
antonwolfy merged 8 commits intomasterfrom May 15, 2025
Merged
make array Hermitian before calling complex-to-real FFT#2444antonwolfy merged 8 commits intomasterfrom
antonwolfy merged 8 commits intomasterfrom
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_20 ran successfully. |
vtavana
requested review from
AlexanderKalistratov,
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
antonwolfy
reviewed
May 13, 2025
antonwolfy
approved these changes
May 14, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @vtavana, LGTM
github-actions bot
added a commit
that referenced
this pull request
May 15, 2025
In this PR, input array is made Hermitian before calling complex-to-real FFT. Input array should be Hermitian before calling complex-to-real FFT otherwise the behavior is undefined. Although it is user responsibility to validate this feature, [NumPy](https://github.com/numpy/numpy/blob/maintenance/2.2.x/numpy/fft/_pocketfft_umath.cpp#L265) and [CuPy](https://github.com/cupy/cupy/blob/v13.4.1/cupy/fft/_fft.py#L109) internally make the input array Hermitian. So, it is done in dpnp for consistency. 8b4a332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, input array is made Hermitian before calling complex-to-real FFT.
Input array should be Hermitian before calling complex-to-real FFT otherwise the behavior is undefined. Although it is user responsibility to validate this feature, NumPy and CuPy internally make the input array Hermitian. So, it is done in dpnp for consistency.