Rename check functions in dpnp_utils_linalg.py#1807
Merged
antonwolfy merged 6 commits intomasterfrom Apr 29, 2024
Merged
Conversation
vlad-perevezentsev
changed the title
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
approved these changes
Apr 29, 2024
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @vlad-perevezentsev, it's a nice change.
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Apr 30, 2024
* Add check_2d to __all__ for dpnp_utils_linalg.py * Rename check_2d to assert_2d * Rename check_stacked_2d to assert_stacked_2d * Rename check_stacked_square to assert_stacked_square --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 6220539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests renaming all check functions (
check_2d(),check_stacked_2d()andcheck_stacked_square()) and updating their doctrings to align their logic according to the comment from #1792 .