Fixed an issue in dpnp.random.vonmises function identified by running tests scope on PVC#1799
Merged
antonwolfy merged 1 commit intomasterfrom Apr 23, 2024
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
vlad-perevezentsev
approved these changes
Apr 23, 2024
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Thank you @antonwolfy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function
dpnp.isnandoesn't support scalar input and raisesTypeErrorexception. But the call with scalar input is using by implementation ofdpnp.random.vonmisesfunction.The PR proposes to always call
numpy.isnanthere instead, because it's secured thatkappais a scalar by a prior check in the code.