Update dpnp.linalg.eig/eigvals#1780
Conversation
|
@antonwolfy also I would also remove the backend implementation of |
We definitely need to plan a clean up, but I would prefer to do that by a separate PR (like to remove all unused linalg functions from backend at once and so on). But needs to be careful to avoid an unexpected impact on numba-dpex. |
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @vlad-perevezentsev
* Remove old impl of dpnp_eig and dpnp_eigvals * Update dpnp.linalg.eig func * Update dpnp.linalg.eigvals func * Update test_sycl_queue with eig and eigvals * Update test_usm_type.py with eig and eigvals * Update TestEigenvalue in test_linalg.py * Remove dpnp_algo_linalg.pyx * Update docstrings for solve and matrix_power --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> ceff0c7
This PR proposes to update
dpnp.linalg.eig()anddpnp.linalg.eigvals()functions usingnumpycall.Using
numpy.linalg.eig/eigvalsis a temporary solution until MKL implementsoneapi::mkl::lapack::geevfor USM interface.This PR also removes
dpnp_algo_linalg.pyxfile because it no longer contains Cython functions