Add support for Aspects #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2021 05:02
diptorupd
reviewed
Mar 3, 2021
Contributor
Author
|
@diptorupd , @oleksandr-pavlyk , I fixed all comments. |
Contributor
|
@1e-to Thanks for the changes. Starting to look good. Couple of additional things that I thought of that we need to do:
|
Contributor
Author
|
@diptorupd, all notes fixed. |
diptorupd
reviewed
Mar 5, 2021
Contributor
|
Last few cosmetic changes and we should be good to go. @oleksandr-pavlyk can you review it once too. |
added 2 commits
March 5, 2021 05:41
Contributor
Author
|
@diptorupd, I fixed everything, but now cpp tests fail if aspect has not been implemented yet. |
diptorupd
reviewed
Mar 5, 2021
diptorupd
previously approved these changes
Mar 5, 2021
Contributor
diptorupd
left a comment
diptorupd
left a comment
There was a problem hiding this comment.
Approved after the last highly cosmetic change is finished.
diptorupd
reviewed
Mar 5, 2021
diptorupd
approved these changes
Mar 9, 2021
diptorupd
pushed a commit
to diptorupd/dpctl
that referenced
this pull request
Mar 13, 2021
* Add support of Current DPCPP aspects to dpctl. * All aspects are now available in the C API using the `DPCTLDevice_HasAspect` function. * Previous C API functions to get atomics aspects are now removed. * Add utilities functions to convert SYCL aspects to dpctl aspect types and vice-versa * Add a utility function to convert aspects to string. Co-authored-by: etotmeni <[email protected]>
diptorupd
pushed a commit
that referenced
this pull request
Mar 13, 2021
* Add support of Current DPCPP aspects to dpctl. * All aspects are now available in the C API using the `DPCTLDevice_HasAspect` function. * Previous C API functions to get atomics aspects are now removed. * Add utilities functions to convert SYCL aspects to dpctl aspect types and vice-versa * Add a utility function to convert aspects to string. Co-authored-by: etotmeni <[email protected]>
diptorupd
pushed a commit
that referenced
this pull request
Apr 2, 2021
* Add support of Current DPCPP aspects to dpctl. * All aspects are now available in the C API using the `DPCTLDevice_HasAspect` function. * Previous C API functions to get atomics aspects are now removed. * Add utilities functions to convert SYCL aspects to dpctl aspect types and vice-versa * Add a utility function to convert aspects to string. Co-authored-by: etotmeni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #292