Skip to content

Contributions to strided full like pr #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 2 commits into from
Aug 23, 2024
Merged

Contributions to strided full like pr #1809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a3d9e8
Order copy into order='K' allocation task after tasks populating sour…
oleksandr-pavlyk Aug 23, 2024
edf97c6
Correct commend in usm_ndarray_full pybind11 function
oleksandr-pavlyk Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dpctl/tensor/_ctors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,9 +1472,10 @@ def full_like(
X = dpt.broadcast_to(X, sh)
res = _empty_like_orderK(x, dtype, usm_type, sycl_queue)
_manager = dpctl.utils.SequentialOrderManager[sycl_queue]
# populating new allocation, no dependent events
# order copy after tasks populating X
dep_evs = _manager.submitted_events
hev, copy_ev = ti._copy_usm_ndarray_into_usm_ndarray(
src=X, dst=res, sycl_queue=sycl_queue
src=X, dst=res, sycl_queue=sycl_queue, depends=dep_evs
)
_manager.add_event_pair(hev, copy_ev)
return res
Expand Down
2 changes: 1 addition & 1 deletion dpctl/tensor/libtensor/source/full_ctor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ usm_ndarray_full(const py::object &py_value,
sycl::queue &exec_q,
const std::vector<sycl::event> &depends)
{
// start, end should be coercible into data type of dst
// py_value should be coercible into data type of dst

py::ssize_t dst_nelems = dst.get_size();

Expand Down