Skip to content

Do not push_back compute event to host_tasks list #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 4 commits into from
Aug 24, 2024
Merged

Do not push_back compute event to host_tasks list #1807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
265bb7f
Do not push_back compute event to host_tasks list
oleksandr-pavlyk Aug 22, 2024
d34de92
Do not add computation event to host_task_lists
oleksandr-pavlyk Aug 24, 2024
20cdd5d
Fixes more compute events added to lists tracking host tasks
ndgrigorian Aug 24, 2024
60969b4
Merge pull request #1811 from IntelPython/fix-additional-compute-even…
ndgrigorian Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions dpctl/tensor/libtensor/source/boolean_advanced_indexing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,6 @@ py_extract(const dpctl::tensor::usm_ndarray &src,
host_task_events.push_back(cleanup_tmp_allocations_ev);
}

host_task_events.push_back(extract_ev);

sycl::event py_obj_management_host_task_ev = dpctl::utils::keep_args_alive(
exec_q, {src, cumsum, dst}, host_task_events);

Expand Down Expand Up @@ -691,8 +689,6 @@ py_place(const dpctl::tensor::usm_ndarray &dst,
host_task_events.push_back(cleanup_tmp_allocations_ev);
}

host_task_events.push_back(place_ev);

sycl::event py_obj_management_host_task_ev = dpctl::utils::keep_args_alive(
exec_q, {dst, cumsum, rhs}, host_task_events);

Expand Down
2 changes: 0 additions & 2 deletions dpctl/tensor/libtensor/source/linalg_functions/dot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,6 @@ py_dot(const dpctl::tensor::usm_ndarray &x1,
});
});
host_task_events.push_back(cleanup_tmp_allocations_ev);
host_task_events.push_back(dot_ev);
}
else { // if (call_batched)
using shT = std::vector<py::ssize_t>;
Expand Down Expand Up @@ -802,7 +801,6 @@ py_dot(const dpctl::tensor::usm_ndarray &x1,
});
});
host_task_events.push_back(cleanup_tmp_allocations_ev);
host_task_events.push_back(dot_ev);
}
}
return std::make_pair(
Expand Down
6 changes: 0 additions & 6 deletions dpctl/tensor/libtensor/source/repeat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,6 @@ py_repeat_by_sequence(const dpctl::tensor::usm_ndarray &src,
host_task_events.push_back(cleanup_tmp_allocations_ev);
}

host_task_events.push_back(repeat_ev);

sycl::event py_obj_management_host_task_ev = dpctl::utils::keep_args_alive(
exec_q, {src, reps, cumsum, dst}, host_task_events);

Expand Down Expand Up @@ -504,7 +502,6 @@ py_repeat_by_sequence(const dpctl::tensor::usm_ndarray &src,
});
});
host_task_events.push_back(cleanup_tmp_allocations_ev);
host_task_events.push_back(repeat_ev);

sycl::event py_obj_management_host_task_ev = dpctl::utils::keep_args_alive(
exec_q, {src, reps, cumsum, dst}, host_task_events);
Expand Down Expand Up @@ -734,8 +731,6 @@ py_repeat_by_scalar(const dpctl::tensor::usm_ndarray &src,
host_task_events.push_back(cleanup_tmp_allocations_ev);
}

host_task_events.push_back(repeat_ev);

sycl::event py_obj_management_host_task_ev =
dpctl::utils::keep_args_alive(exec_q, {src, dst}, host_task_events);

Expand Down Expand Up @@ -846,7 +841,6 @@ py_repeat_by_scalar(const dpctl::tensor::usm_ndarray &src,
});

host_task_events.push_back(cleanup_tmp_allocations_ev);
host_task_events.push_back(repeat_ev);

sycl::event py_obj_management_host_task_ev =
dpctl::utils::keep_args_alive(exec_q, {src, dst}, host_task_events);
Expand Down