Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Jul 27, 2024

Changes to fix dpctl to pass test suite with NumPy 2.0 on Windows.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Jul 27, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_175 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_176 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Introduced default_device_uint_type, parallel to
default_device_int_type.

For NumPy >= 2 (as checked at runtime), it returns "i8" (since dpctl
is only supported on x86_64) or unsigned "u8", while for NumPy < 2 it
returns long ("l"), or 'unsigned long' ("L").
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_171 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review July 27, 2024 17:47
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no impact on DPNP, all tests pass. And the code changes looks good to me.
Thank you @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit 5107bbb into build-with-numpy-2.0 Jul 28, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the align-to-np2-py312 branch July 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants