Fix crash testing with sycl nightly runtime #1762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used info::device::partition_properties and info::device::partition_affinity_domains to check whether give device can be partitioned as requested before calling create_sub_devices method.
1. Do not install FPGA emulator (reduces bandwidth, no longer supported by DPC++) 2. Install latest NumPy in build/test environment (removed <1.26.0 restriction in pip install command)
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_171 ran successfully. |
Collaborator
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_172 ran successfully. |
ndgrigorian
approved these changes
Jul 28, 2024
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
Nightly build now works so LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves SYCLInterface functions
DPCTLDevice_CreateSubDevicesEqually,DPCTLDevice_CreateSubDevicesByCounts, andDPCTLDevice_CreateSubDevicesByAffinity.These now check whether given device supports respective partition property before attempting it. If the input device does not support it,
nullptris returned without error logged.Furthermore,
DPCTLDevice_CreateSubDevicesByAffinitychecks whether the input device supports partitioning over request affinity domain, and returnsnullptrwithout error logged if it does not.This changes became necessary since nightly SYCL bundles are now built with assertions on, and runtime hits an assertion specifying
info::partition_affinity_domain::not_applicablewhich is not meant to be used as an input.