Remove existing IPP directory before moving (release branch) #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for backporting #287. The problem happens on mac for all modules that depend on another remote module. Can you rebase and fix conflicts before I give my approval please? otherwise looks good to me. |
Fixes the following issue when building a module depending on another remote module: mv: rename ITKPythonPackage to /Users/svc-dashboard/D/P/ITKPythonPackage: Directory not empty
Member
Author
|
Rebased. I don't know how I didn't see I was brining in multiple commits originally. |
hjmjohnson
reviewed
Feb 5, 2025
thewtex
requested changes
Feb 5, 2025
Member
There was a problem hiding this comment.
Removing the directory is not the right approach. This could contain work on a non-CI system and it could contain desirable build artifacts from other modules.
If it is the mv on line 92 that is causing the issue, then do not perform the mv if the directory already exists.
Member
|
#287 should be reverted. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #287 for merging into
releasebranch.