Open
Conversation
nsenave
reviewed
Mar 10, 2026
src/main/java/fr/insee/genesis/controller/rest/responses/RawResponseController.java
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/RawResponseController.java
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/RawResponseController.java
Show resolved
Hide resolved
src/test/java/fr/insee/genesis/stubs/LunaticJsonRawDataPersistanceStub.java
Outdated
Show resolved
Hide resolved
src/test/java/fr/insee/genesis/stubs/RawResponseDataPersistanceStub.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataService.java
Show resolved
Hide resolved
Hajarel-moukh
force-pushed
the
devReprocessRawDatas
branch
from
b988834 to
9f747cd
Compare
|
alexisszmundy
requested changes
Mar 27, 2026
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RequestMethod; | ||
| import org.springframework.web.bind.annotation.RequestParam; | ||
| import org.springframework.web.bind.annotation.*; |
| @Override | ||
| @Deprecated(since = "1.13.0") | ||
| public DataProcessResult processRawData(String campaignName, List<String> interrogationIdList, List<GenesisError> errors) throws GenesisException { | ||
| public DataProcessResult processRawData(String questionnaireId, List<String> interrogationIdList, List<GenesisError> errors) throws GenesisException { |
Contributor
There was a problem hiding this comment.
Issue: Cette méthode va être supprimée avec le nettoyage
Suggestion: Créer une nouvelle méthode byQuestionnaireId plutôt que modifier une méthode deprecated
src/main/java/fr/insee/genesis/controller/rest/responses/RawResponseController.java
Show resolved
Hide resolved
| import fr.insee.genesis.domain.model.surveyunit.Mode; | ||
| import fr.insee.genesis.domain.model.surveyunit.SurveyUnitModel; | ||
| import fr.insee.genesis.domain.model.surveyunit.VariableModel; | ||
| import fr.insee.genesis.domain.model.surveyunit.*; |
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.time.format.DateTimeFormatter; | ||
| import java.util.*; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajout de services de "reprocess" des données brutes vers le format Genesis.
Logique du reprocess