This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Merged
Conversation
Member
|
We have to drop the support for py36 as here |
Member
|
ok, if you agree I think that this PR is ready to be merged |
Contributor
Author
|
I agree |
Member
|
Ok, it seems to me that we just have to drop py36 from the CI meantime I approve this PR :) |
peppelinux
approved these changes
Feb 22, 2022
Contributor
Author
|
Yepp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using plain OIDC there are only two options regarding client_id: either it's set statically or it's received as the result of a
dynamic registration.
Under Federation OIDC there is a third state. If automatic registration is used the client_id is not set per OP neither is it
registered with the OP. The up come of this was that attribute client_id was not set in the Client instance creating problem down the line. Adding and using the get_client_id() fixed this problem since the entity/client would know where to find the client_id.