Skip to content

ability to add plugin to user#11

Open
HariHive wants to merge 1 commit intomainfrom
feature/ability-to-add-plugin-to-user
Open

ability to add plugin to user#11
HariHive wants to merge 1 commit intomainfrom
feature/ability-to-add-plugin-to-user

Conversation

@HariHive
Copy link

@HariHive HariHive commented Feb 4, 2026

No description provided.

@HariHive HariHive requested a review from mazar-farran February 4, 2026 23:29
return res.json()

def add_plugin_to_user(plugin_name, plugin_secret):
config_url = f'http://127.0.0.1:5000/api/1/config'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm with Evan if this needs to be invoked on the device? It seems easier for the user to invoke this from their laptop instead using 192.168.0.10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cleaner for this tool to delegate to the dashcam to call the endpoint, and any session revalidation edge cases are handled/etc. Having said that, as long the identity is coming from the dashcam it should get the job done

Copy link
Collaborator

@mazar-farran mazar-farran Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it would be feasible to have such an endpoint. The user could have been logged in from multiple different sources (e.g. phantom account via app or Beekeeper). The phantom authentication is completely handled by the app, and the only thing these login methods have in common is that they store a cookie on the device


Concerning the previous question, is there any concern with deploy.py running from the laptop? Copying the script to the device and running seems unnecessary

@mazar-farran mazar-farran requested a review from evanmoss February 4, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants