Update Endpoints samples:#706
Merged
theacodes merged 6 commits intoGoogleCloudPlatform:masterfrom Dec 13, 2016
Merged
Conversation
Contributor
sepehre
commented
Dec 8, 2016
sepehre
commented
- Change default service names to the new cloud.goog format.
- Change app.yaml beta_settings to endpoints_api_service.
1. Change default service names to the new cloud.goog format. 2. Change app.yaml beta_settings to endpoints_api_service.
googlebot
added
the
cla: yes
Contributor
Author
|
Please do not merge until documentation updated have been coordinated. |
theacodes
added
the
do not merge
theacodes
suggested changes
Dec 8, 2016
endpoints/getting-started/app.yaml
Outdated
| # Specify the Open API specification. | ||
| endpoints_swagger_spec_file: openapi.yaml | ||
| endpoints_api_service: | ||
| name: ENDPOINTS SERVICE-NAME # To be replaced. |
Contributor
There was a problem hiding this comment.
To be replaced but by what? Can you update your comment to be more specific?
Contributor
|
@sepehre once approved, let us know when you want to merge. We'll remove the |
theacodes
reviewed
Dec 8, 2016
endpoints/getting-started/app.yaml
Outdated
| # Specify the Open API specification. | ||
| endpoints_swagger_spec_file: openapi.yaml | ||
| endpoints_api_service: | ||
| name: ENDPOINTS SERVICE-NAME # To be replaced by the output of 'gcloud service-management deploy openapi.yaml' command. |
Contributor
There was a problem hiding this comment.
Okay - one last nit - place these comments on the line above and wrap at 80 characters, please.
theacodes
approved these changes
Dec 8, 2016
Contributor
Author
|
Please merge. |
theacodes
added
API/client update
and removed
do not merge
chalmerlowe
pushed a commit
that referenced
this pull request
Feb 19, 2026
9 tasks
chalmerlowe
pushed a commit
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.