Give option to create a POST check.#3856
Closed
slz250 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Closed
Give option to create a POST check.#3856slz250 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
slz250 wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
In the create call demo -- allow uncommenting of POST check code. This is a new feature and will help drive adoption.
googlebot
added
the
cla: yes
kokoro-team
removed
the
kokoro:run
gguuss
approved these changes
May 21, 2020
Contributor
gguuss
left a comment
gguuss
left a comment
There was a problem hiding this comment.
LGTM as lint is passing and this is just a comment change.
Do you want to just expose this as a comment or would it make sense to add an additional example and also add a test for the POST check?
It may be worth getting someone closer to monitoring on the DPE side for a second approval.
kokoro-team
removed
the
kokoro:run
Contributor
|
As @gguuss mentioned, it might be better to have another sample with a test. |
busunkim96
suggested changes
Jun 12, 2020
Collaborator
|
#4082 was just merged |
Collaborator
|
So I definitely did not intentionally unassign @gguuss - it did that when I commented, and now I can't re-add him. 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the create call demo -- allow uncommenting of POST check code. This is a new feature and will help drive adoption.