Skip to content

fix(run/django): use k8s-skaffold pack for image building #13834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 1 commit into from
Feb 17, 2026
Merged

fix(run/django): use k8s-skaffold pack for image building #13834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion run/django/cloudmigrate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# [START cloudrun_django_cloudmigrate_yaml_python]
steps:
- id: "Build Container Image"
name: buildpacksio/pack
name: gcr.io/k8s-skaffold/pack
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, it's better to use a substitution variable for the builder image name. This avoids hardcoding the value and makes it easier to update in one place if needed.

You can add the following to your substitutions block:

  _PACK_IMAGE: gcr.io/k8s-skaffold/pack

And then reference it here.

    name: ${_PACK_IMAGE}

args: ["build", "${_IMAGE_NAME}", "--builder=gcr.io/buildpacks/builder"]

- id: "Push Container Image"
Expand Down
2 changes: 1 addition & 1 deletion run/django/e2e_test_setup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ steps:
--project ${PROJECT_ID}"

- id: "Build Container Image"
name: buildpacksio/pack
name: gcr.io/k8s-skaffold/pack
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, it's better to use a substitution variable for the builder image name. This avoids hardcoding the value and makes it easier to update in one place if needed.

You can add the following to your substitutions block:

  _PACK_IMAGE: gcr.io/k8s-skaffold/pack

And then reference it here.

    name: ${_PACK_IMAGE}

args: ["build", "${_IMAGE_NAME}", "--builder=gcr.io/buildpacks/builder",
"--env", "GOOGLE_PYTHON_VERSION=${_PYTHON_VERSION}"]

Expand Down