fix: refactor stubConsole and restoreConsole methods in repo-tools with sinon dependency#1600
Merged
fhinkel merged 7 commits intoGoogleCloudPlatform:masterfrom Feb 4, 2020
Merged
Conversation
sofisl
requested review from
ace-n,
djmailhot,
fhinkel,
grant and
michaelawyu
as code owners
googlebot
added
the
cla: yes
fhinkel
approved these changes
Feb 4, 2020
Contributor
fhinkel
left a comment
fhinkel
left a comment
There was a problem hiding this comment.
Thanks! Maybe we can do a second refactoring after landing this where we simplify the sinon calls.
| sinon.stub(console, `error`); | ||
| sinon.stub(console, `log`).callsFake((a, b) => { | ||
| if ( | ||
| typeof a === `string` && |
Contributor
There was a problem hiding this comment.
Would the tests pass without this if clause?
Collaborator
Author
There was a problem hiding this comment.
Unfortunately not (at least for this very specific one). I tried with other ones and they also failed, but definitely interested in making it simpler!
…ocs-samples into removeStubRestoreConsole
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.