Conversation
Contributor
lesv
commented
Jun 29, 2017
lesv
commented
- update cloudSql to latest plugin and make the sample a bit cleaner.
- add postgresql sample.
1. update cloudSql to latest plugin and make the sample a bit cleaner. 2. add postgresql sample.
googlebot
added
the
cla: yes
Contributor
Author
|
I'm going to merge, but I'd rather the init method threw all the things I catch. |
Contributor
Author
|
Well, I can't change init() to add the other types, so I'm going to keep this. |
jabubake
reviewed
Jun 29, 2017
| log("connecting to: " + url); | ||
| try { | ||
| Class.forName("com.mysql.jdbc.Driver"); | ||
| conn = DriverManager.getConnection(url); |
Contributor
There was a problem hiding this comment.
(optional/future) instead of DriverManager.getConnection,
connection pooling with commons-bcp : https://mvnrepository.com/artifact/org.apache.commons/commons-dbcp2
| @@ -0,0 +1,24 @@ | |||
| # Copyright 2016 Google Inc. | |||
| @@ -0,0 +1,127 @@ | |||
| /** | |||
| * Copyright 2016 Google Inc. | |||
Shabirmean
pushed a commit
that referenced
this pull request
Nov 14, 2022
* Tag fix * rerun conventional commit
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
* Tag fix * rerun conventional commit
Shabirmean
pushed a commit
that referenced
this pull request
Nov 17, 2022
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.